[Bug 673175] Review Request: mnogosearch - Web indexing and search system for a small domain or intranet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673175

--- Comment #1 from Gerd v. Egidy <gerd at egidy.de> 2011-01-27 11:24:50 EST ---
Testing done:

I have successfully built the package on i686 and x86_64.

I manually checked the program on both architectures in the default
configuration and everything seemed fine.

The upstream maintainer Alexander Barkov checked and approved the default
configuration and other issues like file permissions.

rpmlint run on the installed rpms:

mnogosearch.i686: W: spelling-error %description -l en_US iODBC -> ABC, ADC,
OTB
mnogosearch.i686: W: spelling-error %description -l en_US unixODBC -> exotic,
animistic, inexorable
mnogosearch.i686: W: spelling-error %description -l en_US backends -> back
ends, back-ends, bookends
mnogosearch.i686: W: spelling-error %description -l en_US charset -> char set,
char-set, chaste
mnogosearch.i686: W: spelling-error %description -l en_US fulltext -> full
text, full-text, faultiest
mnogosearch.i686: W: spelling-error %description -l en_US postgresql ->
picturesquely, paradoxical, paradoxically
mnogosearch.i686: W: spelling-error %description -l en_US firebird -> fire
bird, fire-bird, forebode
mnogosearch.i686: W: spelling-error %description -l en_US freetds -> frets,
ferrets, fretted

> I'd say these are all false positives and the spelling is ok.

mnogosearch.i686: W: non-standard-gid /etc/mnogosearch mnogosearch
mnogosearch.i686: E: non-standard-dir-perm /etc/mnogosearch 0750L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/search.htm mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/search.htm 0640L
mnogosearch.i686: W: non-standard-uid /var/lib/mnogosearch mnogosearch
mnogosearch.i686: W: non-standard-gid /var/lib/mnogosearch mnogosearch
mnogosearch.i686: E: non-standard-dir-perm /var/lib/mnogosearch 0750L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/stopwords.conf
mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/stopwords.conf 0640L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/node.xml mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/node.xml 0640L
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/indexer.conf mnogosearch
mnogosearch.i686: W: non-standard-gid /etc/mnogosearch/langmap.conf mnogosearch
mnogosearch.i686: E: non-readable /etc/mnogosearch/langmap.conf 0640L

> There is a reason I don't allow world read access to the config files:
> Usually there are database access credentials in plaintext contained in them.
> This is stated as comment in the .spec

mnogosearch.i686: E: executable-marked-as-config-file
/etc/mnogosearch/indexer.conf

> This is a feature of the mnogosearch default config:
> it contains a shebang, so you can directly call it. It then uses this config to
> call the indexer.
> This is stated as comment in the .spec

mnogosearch.i686: W: no-manual-page-for-binary mguesser
mnogosearch.i686: W: no-manual-page-for-binary mconv
mnogosearch.i686: W: no-manual-page-for-binary mnogosearch-reindex

> mnogosearch does not provide these man pages. The upstream maintainer told me
> he'll look into improving the man pages.

mnogosearch.i686: W: dangerous-command-in-%post chown

> The mnogosearch user must be owner of the default database. Otherwise searching
> and indexing won't work as expected.

mnogosearch-libs.i686: W: no-documentation
mnogosearch-devel.i686: W: no-documentation

> The documentation is all in the %doc section of the main package.

mnogosearch-devel.i686: W: no-manual-page-for-binary udm-config

> mnogosearch does not provide a man page for the devel-configuration program.

mnogosearch-php.i686: W: no-documentation

> The documentation is all in the %doc section of the main package.

mnogosearch-php.i686: W: non-conffile-in-etc /etc/php.d/mnogosearch.ini

> The file is to inform php about a new extension. There is no need for a user
> to ever modify this file.

rpmlint run on the src.rpm:

mnogosearch.src: W: spelling-error %description -l en_US iODBC -> iodic,
iodous, iodism
mnogosearch.src: W: spelling-error %description -l en_US unixODBC -> unixism,
Unicode, unilobed
mnogosearch.src: W: spelling-error %description -l en_US backends -> backbends,
back ends, back-ends
mnogosearch.src: W: spelling-error %description -l en_US charset -> char set,
char-set, chars et
mnogosearch.src: W: spelling-error %description -l en_US combinations ->
combination, combination's, comminations
mnogosearch.src: W: spelling-error %description -l en_US mysql -> mys ql,
mys-ql, myself
mnogosearch.src: W: spelling-error %description -l en_US fulltext -> full text,
full-text, Fullerton
mnogosearch.src: W: spelling-error %description -l en_US sqlite -> sq lite,
sq-lite, stylite
mnogosearch.src: W: spelling-error %description -l en_US postgresql ->
postgraduate, postglacial, postmistress
mnogosearch.src: W: spelling-error %description -l en_US freetds -> Freetown,
freeloads, freeholds

> These are the same spelling false-positives as in the rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.