[Bug 632463] Review Request: qtcontacts-tracker - QtContact tracker storage plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632463

--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2011-01-27 18:55:28 EST ---
A few comments:

This builds fine, though much of the build does not go in parallel due to
issues with the makefile:
make[3]: warning: jobserver unavailable: using -j1.  Add `+' to parent make
rule.

There are a couple of rpmlint complaints that need fixing.  You should see them
when you run rpmlint yourself so I shouldn't need to post them for you. 
But....

qtcontacts-tracker.x86_64: W: incoherent-version-in-changelog 0.20.29-1
['4.8.8-1.fc15', '4.8.8-1']
qtcontacts-tracker.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/qt4/plugins/contacts/libqtcontacts_tracker.so ['/usr/lib64']

The first is simply the fact that the changelog entry seems to have nothing to
do with the version of the package.  The latter you'll need to look into
fixing.

The summary and description are a bit thin; even after reading them I've no
idea what this package is supposed to do.

Why do you disable the tests?  When I see a comment to the effect that you're
removing tests, I'm always going to ask why that's being done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.