[Bug 652987] Review Request: go - The Go programming language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652987

--- Comment #27 from Renich Bon Ciric <renich at woralelandia.com> 2011-01-28 04:49:33 EST ---
(In reply to comment #25)
> Thank you Renich. This version does indeed build in koji.
> 
> 
> rpmlint has a few complaints about it however.
> 
> go.x86_64: E: statically-linked-binary /usr/bin/goinstall
> go.x86_64: E: statically-linked-binary /usr/bin/ebnflint
> go.x86_64: E: statically-linked-binary /usr/bin/gofmt
> go.x86_64: E: statically-linked-binary /usr/bin/godoc
> go.x86_64: E: statically-linked-binary /usr/bin/govet
> go.x86_64: E: statically-linked-binary /usr/bin/goyacc
> go.x86_64: E: statically-linked-binary /usr/bin/cgo
> go.x86_64: E: statically-linked-binary /usr/bin/hgpatch
> 
> 4 packages and 0 specfiles checked; 8 errors, 325 warnings.
> 
> The above errors should really be fixed,
> http://fedoraproject.org/wiki/Packaging/Guidelines#Staticly_Linking_Executables
> 
> A bunch of static libraries were built, and should be in a -static package
> rather than the main one if included at all.
> http://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries

Well, I'll see where your discussion with Ed Marshall culminates; not sure of
what to do.

> Many of the binaries are without manual pages or documentation. (Upstream?)

Yeah, upstream... let's see if it's possible to generate documentation.

> Trivial .spec fix?
> 
> go.x86_64: W: spurious-executable-perm /usr/share/doc/go-20110120/progs/run
> go.x86_64: W: spurious-executable-perm /usr/share/doc/go-20110120/prog.sh
> go.x86_64: W: spurious-executable-perm /usr/share/doc/go-20110120/makehtml
> go.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/go
> go.x86_64: W: spurious-executable-perm
> /usr/share/doc/go-20110120/codelab/wiki/test.sh

Done, I eliminated, for now, the executable files from docs and renamed
bash_completion/go to go.bash

> These subpackages should likely include a LICENSE file if nothing else:
> 
> go-emacs.x86_64: W: no-documentation
> go-vim.x86_64: W: no-documentation

done.

Posted:
http://renich.fedorapeople.org/SPECS/go.spec
http://renich.fedorapeople.org/SRPMS/go-20110120-4.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.