[Bug 673589] Review Request: UpTools - C++ library for hpc, networking, db, memory, etc.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673589

--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-01-30 23:29:46 EST ---
I don't have time to give you now a full list of what should be improved with
the specfile (I'm on my way to the airport), but I can remind you that the
packaging guidelines at
 http://fedoraproject.org/wiki/Packaging/Guidelines
need to be followed. In addition, you also have to pass the review guidelines
at
 http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
in order for the package to be approved.

On a quick glance, the buildroot is not OK, the -devel package stuff is not OK,
you're mixing styles, and you're not owning the %{_includedir}/UpTools/
directory itself.

Furthermore, you should run the tests in the %check phase instead of shipping
them as %doc (for which there would be a loads easier way to do).

Additionally to the Packaging Guidelines, there are a bunch of language /
application specific guidelines that are linked to in the Packaging Guidelines.

Here are some tricks of the trade:
http://fedoraproject.org/wiki/Packaging_tricks
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
http://fedoraproject.org/wiki/Common_Rpmlint_issues

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.