[Bug 674009] New: Review Request: bitten - A continuous integration plugin for Trac

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: bitten - A continuous integration plugin for Trac

https://bugzilla.redhat.com/show_bug.cgi?id=674009

           Summary: Review Request: bitten - A continuous integration
                    plugin for Trac
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: tim at niemueller.de
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://fedorapeople.org/~timn/bitten/bitten.spec
SRPM URL: http://fedorapeople.org/~timn/bitten/bitten-0.6b3-0.1.fc14.src.rpm
Description: Bitten is a Python-based framework for collecting various software
metrics via continuous integration. It builds on Trac to provide an integrated
web-based user interface.

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=2752033

rpmlint: 
bitten.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in,
plugging
bitten-master.noarch: W: spelling-error Summary(en_US) plugin -> plug in,
plug-in, plugging
- false positive

bitten-master.noarch: W: no-documentation
bitten-slave.noarch: W: no-documentation
bitten-slave.noarch: W: no-manual-page-for-binary bitten-slave
- does not exist

bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_configs.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_config.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_coverage.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_admin_master.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_summary_tests.html
bitten-master.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/bitten/templates/bitten_build.html
- HTML templates, need no shebang

bitten-slave.noarch: W: non-standard-uid /var/lib/bitten-slave bitten-slave
bitten-slave.noarch: W: non-standard-gid /var/lib/bitten-slave bitten-slave
bitten-slave.noarch: W: non-standard-uid /etc/bitten-slave.conf bitten-slave
bitten-slave.noarch: W: non-standard-gid /etc/bitten-slave.conf bitten-slave
bitten-slave.noarch: E: non-readable /etc/bitten-slave.conf 0640L
bitten-slave.noarch: W: dangerous-command-in-%postun userdel
- These are all related. We create a bitten-slave user. The bitten slave is run
as this user and it needs to write to its $HOME at /var/lib/bitten-slave
(checking out code and building it). The configuration file may contain
authentication information, hence should not be world-readable. Since it must
be readable by the bitten-slave user, it is owned by this user. The user is
only deleted on uninstall, not on an upgrade, and since it is a system user
specifically for bitten-slave we think it is safe to delete it.

4 packages and 1 specfiles checked; 7 errors, 10 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.