[Bug 596138] Review Request: nss-gui - A graphical user interface for NSS security databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596138

--- Comment #18 from Kai Engert (kaie) <kengert at redhat.com> 2011-01-31 14:42:04 EST ---
Jason, thank you very much for your time, I highly appreciate it.

(In reply to comment #17)
> Indeed, the 0.3.6 version starts in rawhide and seems to function well enough.

glad to hear


> I note that there's only the MPL license text included.

I updated the LICENSE file to include a header, followed by all 3 license
texts.
Released as 0.3.7


> I assume you want to push this to el5, since it appears to have a sufficiently
> new xulrunner.

Yes


> If not, however, you can remove BuildRoot, %clean and the first
> line of %install.

I've added reminder comments to the specfile, so this cleanup can be done
later, after the RHEL 5 package has been branched.


> It is not necessary for you to manually specify a dependency on
> boost-program-options; rpm finds that out on its own.

Ok, thanks, removed.


> This needs a .desktop file. 
> http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

Ok. Added an icon and a desktop file.


New spec file
http://kuix.de/fedora/nss-gui/nss-gui.spec

New SRPM
http://kuix.de/fedora/nss-gui/nss-gui-0.3.7-1.fc14.src.rpm


I believe I have addressed all of your requests.
Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.