[Bug 668090] Review Request: rubygem-railties - Rails internals: application bootup, plugins, generators, and rake tasks.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=668090

--- Comment #9 from Mohammed Morsi <mmorsi at redhat.com> 2011-01-31 15:14:04 EST ---
(In reply to comment #8)
> Spec URL: http://dl.dropbox.com/u/14118661/rubygem-railties.spec
> SRPM URL:
> http://dl.dropbox.com/u/14118661/rubygem-railties-3.0.3-5.fc14.src.rpm 
> 
> koji scratch build: green
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2746333 
> TEST DON'T PASS. 
> Packages built.
> 

Thanks for these updated rpms, since the tests don't pass but we've verified
functionality, could you comment the check section for the time being. I don't
like relying on the fact that 'rake test' doesn't return a non-zero exit code
when the tests fail in railties. You can also comment the BuildRequires needed
for the tests for the time being.


> > 
> > This will only get you to another set of errors. Looking into those its
> > apparent that the railties test suite is dependent on the rails gem itself to
> > work, introducing a circular dependency, thus cannot be included in the rpm. I
> > verified the functionality though through use via the rubygem-rails package.
> > 
> > With this you can remove (or at least comment out) quite a few things relating
> > to the test suite. Also remove the bits deleting the .empty_directory files.
> > After that I'll approve.
> 
> I saw test suite and look only circular dependency to rails's gems. I am not
> ready break these loops.
> 
> May I offer:
> 1. Remove all test suite.
> 2. Build clear gem rpm.
> 3. Prepare test suite rpm. 
> 3. After build all rpms, build test suite rpm and run it.
> 
> Source 'railties' found in the same git-repo where found 'rails' and other
> basis of rails.
> Rails's developer tests all together.
> My opinion we must go the same way - 
> 1 - Build all, 2 - Install all, 3 - Test all after all.
> 
> PS. Packages that can test separately, build with test suite. For another
> packages make separate post-build/installation test-suite rpm.
> railties-test-<ver>....rpm

We won't be able to do this for Fedora. Each RPM is its own self-contained unit
with explicit dependencies. We can't have circular build time dependencies and
can't execute an rpm's test suite in another rpm's spec. Each rpm needs to be
able to be independently built, installed, and verified

Again thanks for the update. Everything looks good save the running of the test
suite and one additional nit. As with the mail gem, the "fix any executable
that doesn't have a shebang" and "find files with a shebang that do not have
executable permissions" sections seem to be unnecessary (I checked) and can be
removed (they clutter the rpm build log).

Once these final two changes are done, I'll approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.