[Bug 718317] Review Request: asforza4 - 4-in-a-row in a dockapp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=718317

--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de> 2011-07-03 07:54:45 EDT ---
(In reply to comment #2)
> Hm, there's no "-shared" switch in the Makefile.

There are some additional Makefiles in the plugin subfolders
(asforza4/plugin/asf4*/). They call gcc with option -shared.


> > - I think the themes and guile files should be moved from %{_libdir}/%name to
> >   %{_datadir}/%name
> > 
> How can I do so? Patching the Makefile?

Yes, and I fear you also have to patch the sources so that the application
looks up the files in the right place. But that shouldn't be too complicated.
I'll have a look at this later today.


> My idea
> was a sed command to change this line conditionally. But I've no idea how "sed"
> works... Of course, for now the x86_64 build still fails.

Yes, using sed is a good idea. Something like this (in %prep) should do the
job:

%if %{_arch} == x86_64
sed -i 's/ppc386/ppcx64/' asforza4/Makefile
%endif

This sed command replaces (*s*ubstitutes) the character sequence "ppc32" by
"ppcx64" in the given Makefile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.