[Bug 718165] Review Request: ibus-gucharmap - Unicode input engine (using gucharmap) for IBus platform
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jul 4 01:12:08 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718165
Daiki Ueno <dueno at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review Request: |Review Request:
|ibus-gucharmap - Unicode |ibus-gucharmap - Unicode
|input engine (using |input engine (using
|Gucharmap) for IBus |gucharmap) for IBus
|platform |platform
--- Comment #2 from Daiki Ueno <dueno at redhat.com> 2011-07-03 21:12:07 EDT ---
(In reply to comment #1)
> Suggestions
> 1) I think you can use word "Gucharmap" as "gucharmap" as its the command name
> actually in %description and summary.
Done.
> 2) defattr(-,root,root,-) is not needed now as per new guidelines and its also
> pointless since rpm 4.4 version. See
> https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
Removed that line.
> 3) Is the Versioned Requires on ibus really a hard requirement to be mentioned
> in spec? you should just write
> Requires: ibus
Well, I'm not sure if it is assured that ibus engines compiled against specific
ibus-devel version do not install when only older ibus version is available.
For safe, I would like to keep the hard requirement.
> 4) Steps to reproduce tarball is not working
> git archive --format tar --prefix ibus-gucharmap-${ibusgucharmapcommit}
> ${ibusgucharmapcommit} |gzip -c >
> ../ibus-gucharmap-${ibusgucharmapcommit}.tar.gz
> ==> fatal: Not a valid object name
Thanks, I didn't pushed the local commit to the repo. Fixed.
> Though not relevant here but I see build.log is showing same warning many
> times. Looks something like casting issue.
This is a gucharmap bug, which is known to be harmless:
https://bugzilla.gnome.org/show_bug.cgi?id=653214
> Also, it showed zh_CN.po warning message.
Fixed.
Spec URL: http://ueno.fedorapeople.org/ibus-gucharmap/ibus-gucharmap.spec
SRPM URL:
http://ueno.fedorapeople.org/ibus-gucharmap/ibus-gucharmap-1.3.99.20110704-0.1.gitc94104372.fc15.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list