[Bug 711764] Review Request: osc-source_validator - osc source validator

Wed Jul 6 14:29:17 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=711764

--- Comment #12 from Haïkel Guémar <karlthered at gmail.com> 2011-07-06 10:29:15 EDT ---
$ rpmlint -iv osc-source_validator-0.1-3.fc15.src.rpm                          

                                 (0)
osc-source_validator.src: I: checking
osc-source_validator.src: W: spelling-error Summary(en_US) validator ->
invalidator, validation, validate
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.src: W: spelling-error %description -l en_US validator ->
invalidator, validation, validate
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.src: W: spelling-error %description -l en_US plugin ->
plug in, plug-in, plugging
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.src: W: spelling-error %description -l en_US openSUSE ->
opens Use, open SUSE, open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.src: W: spelling-error %description -l en_US pre -> per,
ore, pee
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.src: W: spelling-error %description -l en_US checkin ->
chicken, checking, check in
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.src: I: checking-url
http://en.opensuse.org/openSUSE:Build_Service_Tools#OSC_source_validator
(timeout 10 seconds)
osc-source_validator.src:22: E: hardcoded-library-path in
%{_prefix}/lib/osc/source_validators
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.

osc-source_validator.src:23: E: hardcoded-library-path in
%{_prefix}/lib/osc/source_validators
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.

osc-source_validator.src:28: E: hardcoded-library-path in %{_prefix}/lib/osc
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.

osc-source_validator.src:37: W: macro-in-%changelog %{SOURCE1}
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted.  Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.

osc-source_validator.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

osc-source_validator.src: W: invalid-url Source0:
osc-source_validator-0.1.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 3 errors, 9 warnings.

$ rpmlint -iv
/var/lib/mock/fedora-15-x86_64/result/osc-source_validator-0.1-3.fc15.noarch.rpm

                                                       (64)
osc-source_validator.noarch: I: checking
osc-source_validator.noarch: W: spelling-error Summary(en_US) validator ->
invalidator, validation, validate
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.noarch: W: spelling-error %description -l en_US validator
-> invalidator, validation, validate
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.noarch: W: spelling-error %description -l en_US plugin ->
plug in, plug-in, plugging
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.noarch: W: spelling-error %description -l en_US openSUSE
-> opens Use, open SUSE, open-SUSE
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.noarch: W: spelling-error %description -l en_US pre ->
per, ore, pee
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.noarch: W: spelling-error %description -l en_US checkin ->
chicken, checking, check in
The value of this tag appears to be misspelled. Please double-check.

osc-source_validator.noarch: I: checking-url
http://en.opensuse.org/openSUSE:Build_Service_Tools#OSC_source_validator
(timeout 10 seconds)
osc-source_validator.noarch: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

1 packages and 0 specfiles checked; 0 errors, 7 warnings.

==> rpmlint is OK, but you should fix the macros issue accordingly (not
mandatory but good practice)

==> you should add a comment explaining how you generated the tarball (as you
did with osc) and then i'll approve this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.