[Bug 714231] Review Request: mediawiki116-semantic - The semantic extension to mediawiki

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 6 14:46:37 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714231

--- Comment #3 from James Laska <jlaska at redhat.com> 2011-07-06 10:46:36 EDT ---
(In reply to comment #2)
> Issues: 
> 
> 1. Looks like the skins/SMW_tooltip.js file is under a different LICENSE. (It's
> MIT). 
> Also, there's only one file that says GPLv2 or later. So, I would say the
> License here
> should be: "GPL+ and GPLv2+ and MIT" 

Great catch!  I updated my local .spec and will upload corrected .spec and
src.rpm files after resolving the following question.

> 2. rpmlint says: 
> mediawiki116-semantic.noarch: W: spelling-error %description -l en_US spinoff
> -> spin off, spin-off, Spinoza
> mediawiki116-semantic.noarch: E: incorrect-fsf-address
> /usr/share/doc/mediawiki116-semantic-1.5.6/COPYING
> mediawiki116-semantic.src: W: spelling-error %description -l en_US spinoff ->
> spin off, spin-off, Spinoza
> 
> You might mail them about updating COPYING, others can be ignored. 

I mailed them when submitting the review request (see
https://bugzilla.wikimedia.org/show_bug.cgi?id=29458).  Upstream responded
quickly and has already resolved the problem in svn.  Would you like me to
include the COPYING file from the upstream trunk branch as a patch, or continue
with what is included in the release tarball?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list