[Bug 680936] Review Request: libssh2-python - Python bindings for the libssh2 library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680936

--- Comment #10 from Chris Lalancette <clalance at redhat.com> 2011-07-08 09:20:31 EDT ---
(In reply to comment #8)
> Chris: 
> 
> Please increment release in your spec/srpm when making changes even if trivial,
> it makes it much easier on the reviewer when installing your SRPM. 
> 
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
> 
> In your source URL is there a reason you can't use this as the source URL? 
> https://github.com/wallunit/ssh4py/zipball/0.7.1
> It would still have to be a commented troublesome source url, and it'd screw up
> the macros, but at least it permits upstream source to be verifiable, and less
> work for others. I don't see it as a blocker, but perhaps something to
> consider. 

You are right, I didn't know about the zipball thing.  I've updated the SPEC
now.

(In reply to comment #9)
> A quick other comment, the license field is incorrect: 
> 
> It's currently set as LGPLv2 when it should be LGPLv2+. The source files have
> the 'or (at your option) any later version.' clause in the license declaration 
> of the actual source.

Oh, right.  I've fixed this as well.

A new version of the SPEC and SRPM are available:

http://people.redhat.com/clalance/libssh2-python/libssh2-python-0.7.1-3.fc14.src.rpm
http://people.redhat.com/clalance/libssh2-python/libssh2-python.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.