[Bug 716299] Review Request: clipit - lightweight, fully featured GTK+ clipboard manager

Fri Jul 8 23:46:43 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=716299

--- Comment #6 from Elder Marco <eldermarco at gmail.com> 2011-07-08 19:46:42 EDT ---
Hi Nikos,

I'm not a sponsor (Christoph is a sponsor). I'm not allowed to approve the
package yet. So, this is an informal review.

OK - MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint /var/lib/mock/fedora-15-x86_64/result/clipit-* 
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK - MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
OK - MUST: The package must meet the Packaging Guidelines.
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
    * The license of this package is GPLv3+

OK - MUST: The License field in the package spec file must match the actual
license.
OK - MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
OK - MUST: The spec file must be written in American English.
FIX - MUST: The spec file for the package MUST be legible.
     * It's legible but, if possible, use the full length of a line for the
description, up to 80 characteres. The first and the second lines are OK.

OK - MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
     * Source match the upstream by md5: 0f255859469dbdf8ad5408556cb610b8

OK - MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
     * Koji task Info:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3187630

N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
FIX - MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
    * Please, add gettext as a build dependency. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
    * You need to add the dependencies in Requires. According to the file
src/main.c (line 233) and the README file (line 25) provided by upstream, you
need the package xdotool and the package gtk2. 

OK - MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Packages must NOT bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
OK - MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
OK - MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations).
OK - MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
OK - MUST: Each package must consistently use macros.
OK - MUST: The package must contain code, or permissable content.
N/A - MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
OK - MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
N/A - MUST: Header files must be in a -devel package.
N/A - MUST: Static libraries must be in a -static package.
N/A - MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
N/A - MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
N/A - MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
FIX - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
    * The value "Application" for key "Categories" is deprecated. You can
remove it using desktop-file-install with the option --remove-category. Use
desktop-file-validate to check. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

FIX - SHOULD: At the beginning of the %install section, the package runs rm -rf
%{buildroot}
    * Please, consider to add this command.

OK - MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
OK - MUST: All filenames in rpm packages must be valid UTF-8.

Should Items
============

OK - SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: The reviewer should test that the package builds in mock. 
    * Koji task Info:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3187630
OK - SHOULD: The package should compile and build into binary rpms on all
supported architectures.
FIX - SHOULD: The reviewer should test that the package functions as described.
A package should not segfault instead of running, for example.
    * Well, the package xdotool is a dependency. If you check Settings >
Automatic paste selected item, and select a file from history menu, this
message appears:
        /bin/sh: xdotool: command not found.
    * The icon doesn't appear in system tray (I'm using GNOME 3, Fedora 15),
but you can contact upstream about this.

N/A: SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.
N/A SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb.
OK - SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
OK - SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense

So, some suggestions:
---------------------
    - Use the full length of a line for the description, up to 80 characteres.
See above.
    - Add the packages xdotool and gtk2 (>= 2.10.0) as dependencies. See above
    - Add the package gettext as a build dependency. See above.
    - Please, consider to run the command rm -rf %{buildroot} at the beginning
of the %install section
    - Remove value "Application" from key "Category". See above.
    - Contact upstream about system tray icon, if possible.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.