[Bug 715180] Review Request: freemat - A free environment for rapid engineering, scientific prototyping and data processing

bugzilla at redhat.com bugzilla at redhat.com
Sun Jul 10 21:37:49 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=715180

--- Comment #6 from Volker Fröhlich <volker27 at gmx.at> 2011-07-10 17:37:47 EDT ---
You missed a period between your release number and "svn...".

"svn export https://freemat.svn.sourceforge.net/svnroot/freemat/trunk" is not
the proper command to prepare for producing exactly the same tarball.

In my opinion, the list of BRs is pretty confusing, as it has no specific order
and has multiple BRs per line. That might contibute to having zlib-devel in
there twice ;)

You don't have to BR boost, if you specify boost-devel. The devel package
always requires the main package.

Maybe one "and" in the description should be removed.

Why are you packaging it as a snapshot anyway? There seemingly was a 4.0
release. Is there a specific reason to ship the latest snapshot? This also
leads to questioning the name of the PDF you install, as I couldn't see a 4.1
release on the website, taking a quick look.

I think you should really split the package, as there is loads of documentation
and non-binary data.

Better mention the comment number as well, if you use a reference to a ticket
in the changelog. But actually, this is not extremly helpful. Rather be
explicit there!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list