[Bug 530684] Review Request: nordugrid-arc - Advanced Resource Connector Grid Middleware

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530684

--- Comment #10 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2011-07-11 10:12:44 EDT ---
(In reply to comment #9)

New version:

http://www.grid.tsl.uu.se/review/nordugrid-arc.spec
http://www.grid.tsl.uu.se/review/nordugrid-arc-1.0.0-3.fc15.src.rpm

> rpmlint:
> 
> nordugrid-arc.src: W: spelling-error %description -l en_US middleware -> middle
> ware, middle-ware, middleweight
> The value of this tag appears to be misspelled. Please double-check.
> 
> nordugrid-arc.src: W: spelling-error %description -l en_US organisation ->
> organization, organist, sanitation
> The value of this tag appears to be misspelled. Please double-check.
> 
> nordugrid-arc.src: W: spelling-error %description -l en_US analyse -> analyses,
> analyst, analyze
> The value of this tag appears to be misspelled. Please double-check.
> 
> Fix 2 and 3, skip 1.

Done.

> nordugrid-arc-aris.noarch: E: subsys-not-used /etc/rc.d/init.d/grid-infosys
> While your daemon is running, you have to put a lock file in
> /var/lock/subsys/. To see an example, look at this directory on your machine
> and examine the corresponding init scripts.

This one is a false error. The init script call another script and this scripts
uses the subsys.

> So it looks like most of the problems here relate to doc/man pages and init
> script names.  One suggestion, since as of F-15 we've switched to systemd by
> default, might you not want to create unit files and not provide the sysv init
> scripts?

Several of the missing man pages have been added to upstream's svn and will be
part of the next update.

There is also a separate doc package that contains documentation. (See the
review at bug #704835.)

Converting to systemd unit files is in my plans, but it is not trivial, so it
is not something I can do immediately. Especially the grid-infosys script needs
some care - that one should probably be split into three separate unit files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.