[Bug 719854] Review Request: rubygem-xmlparser-0.6.81-1 - Ruby bindings to the Expat XML parsing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719854

--- Comment #9 from Vít Ondruch <vondruch at redhat.com> 2011-07-12 04:36:52 EDT ---
Hi Ulrich, I am not sponsor so I cannot help with that, but I have several
comments to your package:

1) First of all, the gem seems to be rather old. It seems that upstream
released new version [1] but the update was never released in gem form. Also,
the expat upstream doesn't seems to be extremely vital. So are you really sure
that you like to import the gem into Fedora, instead of considering to
switching to Nokogiri for example?

2) License
The license should be probably "GPLv2+ or Ruby or MIT" and according to readme,
there are also some files licensed under the same terms as Perl.

3) You don't need the ruby_sitelib at all (btw you have type there).

4) BuildRoot is not required anymore

5) %clean section is not required

6) defattr is obsolete

7) You should submit standard build flags for building the C extension:
   export CONFIGURE_ARGS="--with-cflags='%{optflags}'"

8) Since the gem command itself merges all tree steps which are usually
required, i.e. %prep, %build, %install, it is preferred to install the gem in
%build section and then copy it in %install section into final place.

9) There has to be spaces between each changelog entry, otherwise "fedpkg clog"
   fails to extract the log entries correctly. For example
* Wed Jul 06 2011 Ulrich Schwickerath <uschwick at oneadmin03.cern.ch> - 0.6.81-4
- cleaner way to treat SOURCE
- remove explicit dependency on expat
- make globals conditional

* Wed Jul 06 2011 Ulrich Schwickerath <uschwick at oneadmin03.cern.ch> - 0.6.81-3
- fix build problems 


[1] http://www.yoshidam.net/Ruby.html#xmlparser

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.