[Bug 720998] Review Request: OpenNL - A library for solving sparse linear systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720998

--- Comment #3 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-07-14 12:55:42 EDT ---
(In reply to comment #2)
> Hey,
> 
> Just some quick questions about the spec file.
> 
> I'm pretty sure my patch update had cmake creating the correct library
> symlinks. Is there a particular reason you want to create them manually? Also,
> since you've hardcoded the names in %install and %files, you'll have to fix
> this on every version change. 

Really?

With this in the spec:

--------------------------------------------------------------

# Install includes
install -d $RPM_BUILD_ROOT/%{_includedir}/NL/
cp -av src/NL/nl.h $RPM_BUILD_ROOT/%{_includedir}/
find src/NL/ -name "*.h" ! -name "nl.h" -execdir cp -av '{}'
$RPM_BUILD_ROOT/%{_includedir}/NL/ \;

# Create the .so symlinks
#pushd $RPM_BUILD_ROOT/%{_libdir}
#    ln -sfv libopennl.so.3.2.1 libopennl.so
#    ln -sfv libopennl.so.3.2.1 libopennl.so.3
#popd

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

%files
%doc doc 
#%{_libdir}/libopennl.so.3.2.1
#%{_libdir}/libopennl.so.3

%files devel
%doc examples
#%{_libdir}/libopennl.so
%{_includedir}/*

-----------------------------------------------------------

mock fails saying this:

DEBUG: Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
DEBUG: Processing files: OpenNL-debuginfo-3.2.1-2.fc16.i686
DEBUG: Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/OpenNL-3.2.1-2.fc16.i386
DEBUG: error: Installed (but unpackaged) file(s) found:
DEBUG:    /usr/lib/libopennl.so.3.2.1
DEBUG:     Installed (but unpackaged) file(s) found:
DEBUG:    /usr/lib/libopennl.so.3.2.1
DEBUG: RPM build errors:

--------------------------------------------------------------

which is why I created the symlinks manually. rpmlint also spewed the "no
shared library symlink" error. Can you please recheck once? I don't think it
generated the symlinks. 

I can replace use macros in the spec. I'll go do that :)

> 
> Other than that, everything looks good. I'm pulling the srpm now for the usual
> checks.
> 
> Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.