[Bug 688886] Review Request: kflickr - Standalone Flickr Uploader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688886

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(jan.klepek at gmail.
                   |                            |com)

--- Comment #9 from Rex Dieter <rdieter at math.unl.edu> 2011-07-14 12:59:56 EDT ---
Sorry for the delay.

1.  SHOULD: take a look at a template for advice, like,
http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices
and take advantage of some %_kde4_* macros we have.

2.  MUST: use
Requires: kdebase-runtime%{?_kde4_version: >= %{_kde4_version}}
(instead of -libs)

the stuff at the end just adds some extra versioning information, to ensure the
built rpm is run against at least the kde version used to build it.

3.  MUST: fix icon scriptlets, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

4.  SHOULD: drop the convoluted locale handling, and just use something like
%find_lang %{name} --with-kde

Naming OK

License ok

sources ok
a242994345de077c2a4bd07968cc217a  kflickr-20100817.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.