[Bug 722249] Review Request: python-hl7 - Python library parsing HL7 v2.x and v3.x messages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722249

--- Comment #2 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-07-15 11:29:30 EDT ---
Hello,

(In reply to comment #1)
> Hi, 
> 
> just a few things on first look that need addressing before I go any further.
> 
> The header of setup.py states that there should be a file COPYING containing
> the license. I can't see this in the package. 

I'll add it.

> 
> Moreover, it is unclear what the HL7 specification files are referenced under.
> The reference/README.txt states 'This data comes from
> http://www.mirthcorp.com/svn' - which is a broken link. You should also
> consider moving these files to a separate package - if they can be validly
> used, the specs would be useful outside this package.

I found them here:

http://www.mirthcorp.com/community/fisheye/browse/~br=tag%3A2.1.1/Mirth/trunk/generator/reference

Would you want me to split them into a subpackage, or should I package them
separately as a different package all together?

> 
> Also, the removal of \r from these documents may be better suited to a patch.
> The output of your loop is very noisy.

Sure, I'll create one and add it.

> 
> regards,
> 
> Brendan

Thanks, I'll have the spec up in a few hours. 

Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.