[Bug 722707] Review Request: mingw-libvorbis - MinGW Windows libvorbis library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722707

Keiran Smith <fedora at affix.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at affix.me

--- Comment #3 from Keiran Smith <fedora at affix.me> 2011-07-17 02:59:34 EDT ---
This is an informal review

* MUST: The package must be named according to the Package Naming    [ FIX ] 
  Guidelines
Check rpmlint output for mingw-libvorbis-1.3.2-1.fc15.src.rpm
Check rpmlint output for mingw-libvorbis-1.3.2-1.fc15.rpm

* MUST: The spec file for the package MUST be legible.               [ OK ] 


* Must: Spec file matches base package                               [ OK ] 

* Must: License must be licensed with a Fedora approved license and meet the
  Licensing Guidelines                                               [ OK ]

* Must: License in spec must match actual license                    [ OK ] 

* Must: License file included in %doc                                [ FIX ]
  Note : Include the LICENSE file in the %doc section

* Must: Spec file written in American English                        [ OK ]

* Must: Tar ball matches upstream                                    [ OK ]

* Must: Package successfully builds binary RPMs                      [ FIX ]
Koji build -(f14) http://koji.fedoraproject.org/koji/taskinfo?taskID=3204926
           - Note : Failure to Build f14 Package
Koji build -(f15) http://koji.fedoraproject.org/koji/taskinfo?taskID=3204924
           - Note : Build OK

* Must: No duplicate files                                           [ OK ]

* Must: Macro use must be consistant                                 [ OK ]
Thou, for example:
%dir %{python_sitelib}/pynag
Can be written as
%dir %{python_sitelib}/%{name}

* Must: At the beginning of %install, each package MUST run rm -rf %{buildroot}
                                                                     [ FIX ]

* Must: All filenames in rpm packages must be valid UTF-8            [ OK ]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.