[Bug 718317] Review Request: asforza4 - 4-in-a-row in a dockapp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=718317

--- Comment #7 from Martin Gieseking <martin.gieseking at uos.de> 2011-07-17 13:28:30 EDT ---
(In reply to comment #6)
> Sorry for the horrible delay (and many thanks for the patch, of course). 

Not a problem at all. I've also been pretty busy lately.

> The package builds now for both i386 and x86_64

Yes, partly. Unfortunately, the plugin binaries are not yet compiled on x86_64.
As you can see in the build log [1], option -fPIC is still missing when calling
gcc -shared. You should patch the Makefiles in the subfolders as mentioned in
comment #1. If you need help with this, let me know.

In the previously attached patch, I forgot to adapt another line of file
asforza4.c: Replace ASLIBDIR with ASDATADIR in line 2538 too. Otherwise, the
app doesn't find the themes.

As a cosmetic improvement I suggest to use consistent patch filename extensions
(.patch is probably the most common one).

[1] http://koji.fedoraproject.org/koji/getfile?taskID=3205320&name=build.log

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.