[Bug 522920] Review Request: tnef - Extract files from email attachments like winmail.dat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522920

Andrew Colin Kissa <andrew at topdog.za.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #31 from Andrew Colin Kissa <andrew at topdog.za.net> 2011-07-18 08:49:37 EDT ---
[x]  MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.

rpmlint rpmbuild/SRPMS/tnef-1.4.8-3.fc15.src.rpm
rpmbuild/RPMS/x86_64/tnef-1.4.8-3.fc15.x86_64.rpm 
tnef.src: I: enchant-dictionary-not-found en_US
tnef.x86_64: E: incorrect-fsf-address /usr/share/doc/tnef-1.4.8/COPYING
tnef.x86_64: W: no-manual-page-for-binary tnef.sh
2 packages and 0 specfiles checked; 1 errors, 1 warnings.

[x]  MUST: The package must be named according to the Package Naming Guidelines
.
[x]  MUST: The spec file name must match the base package %{name}
[x]  MUST: The package must meet the Packaging Guidelines .
[x]  MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[x]  MUST: The License field in the package spec file must match the actual
license.
[x]  MUST: License included in %doc
[x]  MUST: The spec file must be written in American English.
[x]  MUST: The spec file for the package MUST be legible.
[x]  MUST: The sources used to build the package must match the upstream
source.

sha1sum tnef-1.4.8.tar.gz rpmbuild/SOURCES/tnef-1.4.8.tar.gz 
19431176ee523fe3fd5e745882a9083426cc5671  tnef-1.4.8.tar.gz
19431176ee523fe3fd5e745882a9083426cc5671  rpmbuild/SOURCES/tnef-1.4.8.tar.gz

[x]  MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[x]  MUST: If the package does not successfully compile, build or work on an
architecture, it should be listed in ExcludeArch.
[x]  MUST: All build dependencies must be listed in BuildRequires
[N/A]  MUST: The spec file MUST handle locales properly.
[N/A]  MUST: Every binary RPM package (or subpackage) which stores shared
library files must call ldconfig
[x]  MUST: Packages must NOT bundle copies of system libraries.
[N/A]  MUST: If the package is designed to be relocatable, must state this
fact.
[x]  MUST: A package must own all directories that it creates.
[x]  MUST: A Fedora package must not list a file more than once.
[x]  MUST: Permissions on files must be set properly.
[x]  MUST: Each package must consistently use macros.
[x]  MUST: The package must contain code, or permissable content.
[x]  MUST: Large documentation files must go in a -doc subpackage.
[x]  MUST: If a package includes something as %doc, it must not affect the
runtime of the application
[N/A]  MUST: Header files must be in a -devel package.
[N/A]  MUST: Static libraries must be in a -static package.
[N/A]  MUST: Library files that end in .so must go in a -devel package.
[N/A]  MUST: Devel packages must require the base package using a fully
versioned dependency.
[x]  MUST: Packages must NOT contain any .la libtool archives.
[x]  MUST: GUI applications must include a %{name}.desktop file, installed with
desktop-file-install
[x]  MUST: Packages must not own files or directories already owned by other
packages. 
[x]  MUST: All filenames in rpm packages must be valid UTF-8.

-------------------------------------------------------------------
   This package (tnef) is APPROVED by topdog
-------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.