[Bug 720085] Review Request: perl-Net-FTP-AutoReconnect - FTP client class with automatic reconnect on failure

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720085

--- Comment #5 from Richard Shaw <hobbes1069 at gmail.com> 2011-07-18 10:47:14 EDT ---
Spec review results:

Everything looked good but I have some questions about the %files section:
"""
%files
%defattr(-,root,root,-)
%doc
%{perl_vendorlib}/*
%{_mandir}/man3/*.3*
%doc t
"""

1. Is there something special about having two %doc sections, one of which is
blank?

2. Is "%{perl_vendorlib}/*" appropriate?
"""
$ rpm -qlp perl-Net-FTP-AutoReconnect-0.3-2.fc14.noarch.rpm
/usr/share/doc/perl-Net-FTP-AutoReconnect-0.3
/usr/share/doc/perl-Net-FTP-AutoReconnect-0.3/t
/usr/share/doc/perl-Net-FTP-AutoReconnect-0.3/t/00compile.t
/usr/share/man/man3/Net::FTP::AutoReconnect.3pm.gz
/usr/share/perl5/Net
/usr/share/perl5/Net/FTP
/usr/share/perl5/Net/FTP/AutoReconnect.pm
"""

This causes the package to own the directories:
/usr/share/perl/Net
and
/usr/share/perl/Net/FTP

Is this standard practice for perl modules? 

Thanks,
Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.