[Bug 666409] Review Request: t4k_common - Library for Tux4Kids applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666409

--- Comment #7 from Martin Gieseking <martin.gieseking at uos.de> 2011-07-18 14:22:05 EDT ---
OK, there are still some issues, sorry. Please recheck the source archives as
that in the SRPM differs from the upstream one:

$ md5sum t4k_common-0.1.1.tar.gz*
e3d5da74971f427e8deb1e904dfcf8ab  t4k_common-0.1.1.tar.gz
28ad0818aa79d701fd33019e756340f8  t4k_common-0.1.1.tar.gz.1

- Also, swap the %defattr and %doc lines in %files devel.

- The latest tarball bundles liblinebreak (in src/linebreak). As linking of
  bundled libraries is not permitted, please adapt the sources to use the 
  liblinebreak package from the Fedora repo.

- Think about dropping doxygen/html/installdox. It's an installation script not
  required by the user. Removing this file will also make rpmlint happy.


$ rpmlint *.rpm
t4k_common.src: W: file-size-mismatch t4k_common-0.1.1.tar.gz = 629215,
https://alioth.debian.org/frs/download.php/3439/t4k_common-0.1.1.tar.gz =
575582
t4k_common.x86_64: W: shared-lib-calls-exit /usr/lib64/libt4k_common.so.0.0.0
exit at GLIBC_2.2.5
t4k_common-devel.x86_64: W: doc-file-dependency
/usr/share/doc/t4k_common-devel-0.1.1/html/installdox /usr/bin/perl
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.