[Bug 675050] Review Request: cloudfs - Cloud Filesystem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675050

--- Comment #22 from David Nalley <david at gnsa.us> 2011-07-19 10:54:09 EDT ---
(In reply to comment #20)
> Sorry I missed you on IRC.
> 
> | WRT License field, I still see GPLv2 and AGPLv3+ in the source tarball.
> 
> Since none of the real source is GPLv2 I gather you're referring to the various
> autoconf and libtool scripts that configure had copied into the tree and were
> rolled into the tarball. They're now gone from the source tarball.

So there are really two problems here: 
The first is that you list AGPLv3, when the actual license is AGPLv3+
(e.g. it contains the phrase 'or at your option any later version' 

The second is that the source tarball you are distributing has code that's
GPLv2 (I took the source tarball from the SRPM and ran grep -ir license ./*
after uncompressing it, and what's being distributed is GPLv2 and AGPLv3+ in
source, which is what the license field tells folks about.) Even if you don't
use that source at all in the final binary. 

I can't see that it's been removed from the 0.7 tarball, but feel free to
correct me if I have missed something. 


> 
> | You still have this problem:
> | warning: File listed twice: /var/run/cloudfs/idle_ports
> | warning: File listed twice: /var/run/cloudfs/used_ports
> 
> They weren't in the spec file twice, but I've managed to eliminate that
> warning. It's not clear to me why it was emitting that warning, maybe because
> those are subdirs and (or but) it was stripping off {idle,used}_ports and
> whining about /var/run/cloudfs being there twice? Anyway, it's gone.

Great!

> 
> Spec URL: http://cloudfs.org/dist/0.7/cloudfs.spec
> SRPM URL: http://cloudfs.org/dist/0.7/cloudfs-0.7-4.fc15.src.rpm
> 
> successful builds in mock, and koji
> https://koji.fedoraproject.org/koji/taskinfo?taskID=3210066 (i386)
> https://koji.fedoraproject.org/koji/taskinfo?taskID=3210050 (x86_64)
> 
> rpmlint same as #18 above (even though I've added man pages)

Wow, thats awesome, thanks for going the extra step and adding man pages! 


To sum up I think the remaining blockers are the license field and possibly
license conflict issue, any status on that?? Is it a non-issue?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.