[Bug 644711] Review Request: diaser - disk based backup volume accumulator, replication and management system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644711

--- Comment #12 from Martin Gieseking <martin.gieseking at uos.de> 2011-07-19 14:29:03 EDT ---
Damian, here are some further comments:

- the packaged tarball doesn't match the upstream one:
  $ md5sum diaser-1.1.0.tar.gz*
  a5d02d89d83673715a1367e94ac1a580  diaser-1.1.0.tar.gz
  131e3f03b84aa6f557943b17b1a4baf5  diaser-1.1.0.tar.gz.1

  Please recheck this.

- Is diaser a plain sysadmin tool and should thus be placed in /usr/sbin, or 
  could it be useful for regular users as well? In the latter case move the
  script to /usr/bin. Otherwise, the manpage should go to section 8 (and should 
  be fixed upstream).

- The tarball contains a config file (diaser.conf). Shouldn't it be part of 
  the package (at least as an example file)?

- Please use macros consistently in %install and %files: either use %{name}
  or "diaser" but don't mix them.

- The %changelog is supposed to list changes to the package/spec only
  (downstream updates). Changes to the program sources (upstream) don't belong 
  there. Just replace your latest entry by "updated to release 1.1.0" or the
  like.

- Please add the revision number to each changelog record, as documented here:
  http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs


$ rpmlint /var/lib/mock/fedora-15-x86_64/result/*.rpm
diaser.noarch: W: incoherent-version-in-changelog 1.1.0 ['1.1.0-1.fc15',
'1.1.0-1']
diaser.src: W: file-size-mismatch diaser-1.1.0.tar.gz = 251618,
http://downloads.sourceforge.net/diaser/diaser-1.1.0.tar.gz = 251620
2 packages and 0 specfiles checked; 0 errors, 2 warnings.


BTW, do you already have a sponsor? If not, I can sponsor you if you're willing
to do a couple of informal reviews in order to show that you have an
understanding of the packaging guidelines. Please choose a yet uncommented
review request not blocked by FE-NEEDSPONSOR, e.g. bug #705319, and check the
package for meeting the items listed here:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
There are some more items to consider during a complete review, but checking
the listed ones is a good start.

If you have any questions, let me know.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.