[Bug 719975] Review Request: rubygem-chunky_png - Pure ruby library for read/write, chunk-level access to PNG files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719975

--- Comment #3 from Chris Lalancette <clalance at redhat.com> 2011-07-19 15:13:52 EDT ---
(In reply to comment #2)
> Overall looks good. Koji build is green:
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631
> 
> Specific notes:
> 
> - the requires rubygem(rake) and rubygem(rspec) should be changed to
> buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a
> %check section

I tried doing this, but I haven't been able to successfully run the test suite.
 I'm not sure if the version of rspec is too old, or what, but it always fails
to load some files.  I've removed the two buildrequires for now, and we can
revisit it later on.

> 
> - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby

Fixed.

> 
> - include a "--ri" flag in the gem install command

Fixed.

> 
> - rpmlint complains about the following hidden files which should be removed:
> .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if
> it's needed)

Removed.

> 
> - the following files should be marked as %doc in the %files section: spec/
> directory, license, readme, rakefile, chunky_png.gemspec, benchmarks

Fixed.

> 
> - consider dropping the "also have a look at oilypng..." blurb from the package
> description

Removed.

New SRPM:
http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png-1.2.0-2.fc14.src.rpm
New SPEC:
http://people.redhat.com/clalance/rubygem-chunky_png/rubygem-chunky_png.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.