[Bug 722914] Review Request: volumeicon - Lightweight volume control for the system tray

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722914

--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-07-19 22:59:33 EDT ---
(In reply to comment #1)
> - There is a %clean section even though the package isn't for EPEL
> (http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean)

It doesn't hurt having one, though. In newer versions of Fedora a %clean isn't
necessary anymore, since rpm has a default %clean directive.

> MUST: The License field in the package spec file must match the actual license.
> NOT SURE:
> 
> - licensecheck gives GPLv3, not GPLv3+.

Oh? For me it gave GPLv3 straight away. And, you must always check (one of) the
headers for yourself to see if licensecheck has worked correctly. 

> MUST: The spec file must be written in American English. NEEDSWORK:
> 
> - I don't think that the S in "Volume Slider" needs to be capitalized.

This is nitpicking. But in principle you may be correct.

> - Wouldn't it make sense to place another desktop file in the actual menu for
> this instead of just having an autostart entry?

Doesn't it have one..?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.