[Bug 722914] Review Request: volumeicon - Lightweight volume control for the system tray

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722914

--- Comment #5 from Christoph Wickert <cwickert at fedoraproject.org> 2011-07-20 07:06:29 EDT ---
Thanks Veeti, both are valid points. GPLv3+ is definitely wrong, GPLv3 is
correct.

As for the spelling error: Capitalization can/should be used in the summary but
not in the description.

(In reply to comment #2)
> - As a courtesy to people reading your spec files, please don't use macros in
> the URL if they're not absolutely necessary.

Why not? we have spectool...

> - Patch0 is missing a description in the spec file. Please document what it
> does. Has it been sent upstream?

It fixes linking problems and I sent it upstream by mail. I'll add a comment on
this.

> - Where is Source1 from? Has it been sent upstream?

It's from gnome-media and has not been sent upstream (yet).

(In reply to comment #1)
> - Wouldn't it make sense to place another desktop file in the actual menu for
> this instead of just having an autostart entry? (?)

I don't think so. Icons in the systray are supposed to be persistent throughout
the whole session. They should be started on login and not from the menu.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.