[Bug 722812] Review Request: worker - X11 File manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722812

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #6 from Martin Gieseking <martin.gieseking at uos.de> 2011-07-22 02:53:49 EDT ---
Nathan, if you don't have access to the fedorapeople.org webspace yet, I
suggest to use something like dropbox for example. It's an easy way to upload
and to provide publicly accessible files.

Here are some further comments on your package:

- You can combine the separate file conversions with a loop: 
  cd man
  for f in fr/worker.1 it/worker.1; do
    iconv -f ISO-8859-1 -t UTF-8 $f > $f.new && \
    touch -r $f $f.new && \
    mv $f.new $f
  done

- The package contains a .desktop file that must be properly installed or
  verified with desktop-file-install or desktop-file-validate:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

- Drop line %docdir %{_mandir}/* from %files as the affected directories are
  flagged as docdirs by default. 

- The package currently doesn't own the directory /usr/share/worker/ but only
  its contents. Drop the trailing asterisk from %{_datadir}/worker/* (in 
  %files) to fix this.

- Add the following line to %files:
  %doc AUTHORS ChangeLog COPYING THANKS
  Especially the file containing the license text, if present in the tarball,
  must always be added to the package. 

- Please be more verbose in the %files section and avoid to use single plain
  asterisks. This way it's easier to see what's actually packaged and it also
  helps to prevent adding unwanted files. Also don't add the suffix .gz to 
  the manpage files since the compression format applied by rpmbuild might 
  change:
  %{_bindir}/worker
  %{_datadir}/applications/worker.desktop
  %{_datadir}/pixmaps/WorkerIcon*.xpm
  %{_datadir}/worker/
  %{_mandir}/man1/worker.1*
  %{_mandir}/fr/man1/worker.1*
  %{_mandir}/it/man1/worker.1*

- To increase legibility, please add blank lines before %build and between 
  the %changelog entries. Also, add spaces after "*" and "-" in the 
  %changelog.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.