[Bug 724883] Review Request: biomaj-1.1.0 - BioMAJ is a workflow engine dedicated to data synchronization and processing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=724883

Pierre-YvesChibon <pingou at pingoured.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pingou at pingoured.fr
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #1 from Pierre-YvesChibon <pingou at pingoured.fr> 2011-07-22 04:18:05 EDT ---
I happen to be bioinformaticien, french and sponsor, so let's have a look.

First comments at first glance:
* Please split the lines in your spec. It doesn't fit in my 19" screen. We
normally don't make line longer than 80 characters
* Use %global instead of %define:
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
* Why do you redefine %{name}, %{version} ? (first lines)
* I would prefer to see a direct link to upstream's sources. They want to see
who is using their tool, but they won't be able to with the tool in debian or
Fedora. So as soon as they accept to have their tool packaged, this
"registration" system is rather pointless.
* this is associated with the invalid source0 that rpmlint shows
* your %clean section looks strange to me
* Some comments in %file are not necessary anymore
* on %prep, you might want to use pushd and popd rather then cd ../../....

The full output from rpmlint on all the rpm:
$ rpmlint biomaj-1.1.0-1.fc15.src.rpm 
biomaj.src: W: spelling-error %description -l en_US workflows -> work flows,
work-flows, workloads
biomaj.src: W: spelling-error %description -l en_US bioinformaticians ->
transformations
biomaj.src: W: spelling-error %description -l en_US fasta -> fasts, fast, pasta
biomaj.src: W: invalid-license BSD with attribution
biomaj.src: W: strange-permission Deb2Fedora.sh 0755L
biomaj.src:24: W: macro-in-comment %{name}
biomaj.src:24: W: macro-in-comment %{name}
biomaj.src:24: W: macro-in-comment %{version}
biomaj.src:74: W: macro-in-comment %__cp
biomaj.src:82: W: macro-in-comment %{nonConfigFiles}
biomaj.src:105: W: macro-in-comment %dir
biomaj.src:106: W: macro-in-comment %dir
biomaj.src:107: W: macro-in-comment %dir
biomaj.src:108: W: macro-in-comment %dir
biomaj.src: W: invalid-url Source0: /biomaj-1.1.0.tar.gz
1 packages and 0 specfiles checked; 0 errors, 15 warnings.

$ rpmlint  /home/pierrey/rpmbuild/RPMS/noarch/biomaj-1.1.0-1.fc15.noarch.rpm
biomaj.noarch: W: spelling-error %description -l en_US bioinformaticians ->
transformations
biomaj.noarch: W: spelling-error %description -l en_US fasta -> fasts, fast,
pasta
biomaj.noarch: W: invalid-license BSD with attribution
biomaj.noarch: W: hidden-file-or-dir
/usr/share/biomaj/lib/vendor/commons-cli2/src/test/data/.hidden.txt
biomaj.noarch: W: log-files-without-logrotate /var/log/biomaj
biomaj.noarch: W: class-path-in-manifest /usr/share/biomaj/lib/biomaj.jar
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

I believe some can be fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.