[Bug 723991] Review Request: libvirt-qmf - matahari agent for libvirt (replaces libvirt-qpid)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=723991

--- Comment #1 from Jaroslav Reznik <jreznik at redhat.com> 2011-07-22 07:43:17 EDT ---
Name: ok
Summary: ok
Source: not ok, please provide full sources url if not generated manually (and
then it should be documented)
License: ok
Obsoletes: should be versioned, see rpmlint output
Url: ok
Group: ok but not needed anymore in Fedora
Requires: not ok, please do not use explicit requires (unless it's runtime
dependency not autogenerated by rpm depsolver), ok for scriptlets, see
http://fedoraproject.org/wiki/Packaging:Guidelines#Requires
BuildRequires: ok but qmf-devel is now qpid-qmf-devel (still provides
qmf-devel)
Description: ok
Build: please use parallel make if possible, see
http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - otherwise
document it in comment that it's not possible to use it
Build: scratch build failed, see
http://koji.fedoraproject.org/koji/taskinfo?taskID=3222416
Macros usage consistency: inconsistent %{buildroot} and $RPM_BUILD_ROOT used
together, see http://fedoraproject.org/wiki/Packaging:Guidelines#Macros
Doc: ok
%defattr is not needed explicitely anymore in rpm 4.4+

rpmlint libvirt-qmf-0.3.0-1.fc15.src.rpm 
libvirt-qmf.src: W: spelling-error Summary(en_US) QPid -> QP id, QP-id, Quid
libvirt-qmf.src: W: spelling-error %description -l en_US qpid -> quid, tepid,
cupid
libvirt-qmf.src:9: W: unversioned-explicit-obsoletes libvirt-qpid
libvirt-qmf.src: W: invalid-url Source0: libvirt-qmf-0.3.0.tar.gz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.