[Bug 724942] Review Request: libmodbus - A Modbus library written in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=724942

--- Comment #3 from Peter Lemenkov <lemenkov at gmail.com> 2011-07-22 08:44:31 EDT ---
Few notes:

* Packager field should be removed as per Fedora Policy.
* This line should be removed - "Provides: libmodbus=%{version}"
* Missing BuildRequires: xmlto, asciidoc
* Please, remove [ "%{buildroot}" != "/" ] && %{__rm} -rf %{buildroot} .Ether
drop them entirely (it added by rpmbuild automatically nowadays) or simplify
these lines up to "rm -rf %{buildroot}".
* Move make check into its own section from %install

%check
make check

* Don't use %makeinstall macro. Use make install DESTDIR=$RPM_BUILD_ROOT
instead
* Don't mix make and %{_make} - it's not an issue, it just looks ugly.
* One more proposal to %post and %postup sections. You should simplify them as
following:

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

This will save you two additional bash invocations during build.

* *.la files cannot be packaged at all. Remove it at the end of the %install
section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.