[Bug 724991] Review Request: smokegen - Smoke Generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=724991

--- Comment #2 from Jaroslav Reznik <jreznik at redhat.com> 2011-07-22 11:22:48 EDT ---
Name: ok, matches upstream
Summary: ok
Group: ok, but not needed anymore
License: not ok, LGPLv2 and GPLv2+ (according to discussion with Rex - legal
wants us to list all licenses included in tarball)
Url: not ok, redirects to Techbase and no article can be found there
Source: ok (md5sum dd8dc0f9fb8e2fe5294075855be524a4)
Obsoletes/Provides: ok?, smokegen was part of kdebindings (can all smoke*
related packages provide kdebindigs?)
Description: could be, I'd like to provide more information there, not a
blocker
Ldconfig: ok
Docs: ok, just ping upstream for proper COPYING

Shouldn't we have smokegen-devel? The same way as original kdebindings had it?

Group, BuildRoot, clean section, defattrs not needed anymore

rpmlint
rpmlint smokegen-4.6.95-1.fc15.src.rpm 
smokegen.src: W: invalid-url URL: http://developer.kde.org/language-bindings/
HTTP Error 404: Not Found

> fix pls

smokegen.src: W: invalid-url Source0:
ftp://ftp.kde.org/pub/kde/stable/4.6.95/src/smokegen-4.6.95.tar.bz2 <urlopen
error ftp error: 550 Failed to change directory.>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

> ok, we will have stable soon

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.