[Bug 676608] Review Request: rubygem-delayed_job - Database-backed asynchronous priority queue system -- Extracted from Shopify

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676608

--- Comment #2 from Vít Ondruch <vondruch at redhat.com> 2011-07-25 07:45:27 EDT ---
I have uploaded updated version of delayed_job:

Spec URL: http://people.redhat.com/vondruch/rubygem-delayed_job.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-delayed_job-2.1.4-1.fc16.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3227264

(In reply to comment #1)
> Taking this one. Overall looks good
> 
> - the latest upstream release is 2.1.4, please consider updating

done

> - could you remove references in the summary / description to 'shopify'

done

> - the rspec2 components are now in fedora, can we drop the patch to the spec
> suite?

done

> - there is one rpmlint warning to note:
> rubygem-delayed_job.noarch: E: non-executable-script
> /usr/lib/ruby/gems/1.8/gems/delayed_job-2.1.3/lib/generators/delayed_job/templates/script
> 0644L /usr/bin/env

Actually this is Rails generator template, therefore it contains shebang, while
it is not intended to be executed from current location, so the error is false
positive.

> - defaultattr is no longer necessary in files section an should be removed

done

> - the package should own the %dir %{geminstdir} should it not

done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.