[Bug 723581] aeolus-configure - Aeolus Configure Puppet Recipe

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=723581

--- Comment #3 from Mo Morsi <mmorsi at redhat.com> 2011-07-25 08:43:54 EDT ---
Spec: http://mo.morsi.org/files/aeolus/aeolus-configure.spec
SRPM: http://mo.morsi.org/files/aeolus/aeolus-configure-2.0.1-4.src.rpm


(In reply to comment #2)
> Well, we actually have tarballs now, so we should update this to use the
> tarballs:
> 
> http://repos.fedorapeople.org/repos/aeolus/aeolus-configure/2.0.1/tarball/
> 

Done

> rpmlint complains a bit:
> 
> [clalance at localhost SPECS]$ rpmlint
> aeolus-configure.noarch: E: non-executable-script
> /usr/share/aeolus-configure/modules/aeolus/templates/deltacloud-core 0644L
> /bin/bash
> aeolus-configure.noarch: E: zero-length
> /usr/share/aeolus-configure/modules/ntp/README

> 
> To shut rpmlint up, I would suggest just doing chmod +x on that deltacloud-core
> file, and removing the ntp/README file.

Done.

templates/deltacloud-core is now marked as executable

Removed the empty ntp/README file


> [  OK  ] MUST: The package must meet the Packaging Guidelines
> The Source of the package must be the full URL to the released Gem archive
> See: http://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gems
> http://fedoraproject.org/wiki/Packaging:SourceURL

Done

> [  OK  ] MUST: The package must be licensed with a Fedora approved license
>          and meet the Licensing Guidelines
> [  FAIL  ] MUST: The License field in the package spec file must match the 
>          actual license - clalance: there is no license specified in the
> upstream sources anywhere.  We should push a patch to upstream to make the
> license clear, and also include it in the package.

Seems to be the case w/ a few of the aeolus components. We should go through
and add the license file to them all. We can address this for the next release.
Since the license field is correct in the spec file, leaving this as is for
now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.