[Bug 723756] Review Request: bliss - Compute automorphism groups and canonical labelings of graphs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=723756

Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
               Flag|                            |fedora-review?

--- Comment #1 from Jon Ciesla <limb at jcomserv.net> 2011-07-25 11:05:11 EDT ---
Good:

- rpmlint checks return:

A few trivial and/or erroneous spelling issues and:

bliss-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libbliss.so.0.72
exit at GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

This would be reaaaally good to fix, or at least nag upstream about.

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv3 ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

EXTRA STUFF FOR PACKAGES WITH DEVEL
==========================

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

So, looks good, generally.  I'm running a mock build to double-check BRs, and
I'm curious on your views vis-a-vis exit().

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.