[Bug 711547] Review Request: sketch - Free Graphics Software for the TeX, LaTeX, and PSTricks Community
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jul 25 18:18:35 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711547
--- Comment #16 from Richard Shaw <hobbes1069 at gmail.com> 2011-07-25 14:18:34 EDT ---
I think what Kevin was referring to is that you've incremented the releases
appropriately in the changelog but "Release:" in your spec file (and therefore
the resulting SRPM) is still "1".
Some other thoughts...
1. I would remove "%check" since it's empty.
2. This only aids readability, but I always leave two empty lines between major
sections in the spec file, i.e: Between %prep, %build, %install, %files, etc.
3. The last line in your %files section has "#doc Doc/" instead of "%doc Doc/",
is this intentional?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list