[Bug 725310] Review Request: osdlyrics - Show on-screen lyrics with your favorite media players

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=725310

--- Comment #1 from Michael Schwendt <mschwendt at gmail.com> 2011-07-26 07:08:30 EDT ---
* %{_datadir}/icons/hicolor/*/*/%{name}*

Using desktop-file-utils is still a MUST in the review guidelines:
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop


* yum localinstall osdlyrics...
[...]
Installing:
 osdlyrics                             x86_64                0.4.1-1.fc15      
           osdlyrics-0.4.1-1.fc15.x86_64                827 k
Installing for dependencies:
 avahi-compat-libdns_sd                x86_64                0.6.30-3.fc15     
           fedora                                         30 k
 ecore                                 x86_64                1.0.0-2.fc15      
           fedora                                        215 k
 eet                                   x86_64                1.4.0-2.fc15      
           fedora                                         57 k
 evas                                  x86_64                1.0.0-2.fc15      
           fedora                                        390 k
 libeina                               x86_64                1.0.0-2.fc15      
           fedora                                         95 k
 libmpd                                x86_64                0.20.0-2.fc15     
           fedora                                         49 k
 xmms2                                 x86_64                0.7-8.fc15        
           fedora                                        1.2 M


In other words, it drags in the deprecated xmms2 player because that one
doesn't ship its client library in a subpackage (like XMMS does with
xmms-libs).


* Upon running osdlyrics for the first time, I clicked the "Audacious" icon it
displayed. On subsequent runs, osdlyrics starts Audacious automatically and
fills the playlist with a bad %U entry that causes the player to open an error
dialog:

  Cannot open /home/misc/%U: No such file or directory.
  No decoder found for file:///home/misc/%25U.


* The source code should also not hardcode "audacious2" and "Audacious 2" but
just "audacious", because for example, Rawhide features Audacious 3 already
without the old audacious2 compatibility symlinks in /usr/bin. Those have been
a bad idea and have been removed by upstream since Audacious 2.5.x anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.