[Bug 669911] Review Request: guestfs-browser - Guest filesystem browser

Tue Jul 26 15:14:26 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=669911

--- Comment #8 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-07-26 11:14:24 EDT ---
Review:

+ OK
- NA
? ISSUE

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[ankur at ankur SOURCES]$ md5sum ~/rpmbuild/SPECS/guestfs-browser-0.1.6.tar.gz
guestfs-browser-0.1.6.tar.gz 
c5fde7bc4f4a72d40f675a228332c6d5 
/home/ankur/rpmbuild/SPECS/guestfs-browser-0.1.6.tar.gz
c5fde7bc4f4a72d40f675a228332c6d5  guestfs-browser-0.1.6.tar.gz

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
- Package has %defattr and permissions on files is good.
^^ defattr is not needed after rpm 4.4 iirc,

- Package has a correct %clean section.
^^ The %clean section is not required for F-13 and above. 

- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
^^ Fedora (as of F-10) does not require the presence of the BuildRoot

+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

? Package is a GUI app and has a .desktop file
^^ please include a desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.
[ankur at ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm
../SPECS/guestfs-browser.spec guestfs-browser-0.1.6-1.fc15.src.rpm
guestfs-browser.i686: W: spelling-error Summary(en_US) filesystem -> file
system, file-system, systemically
guestfs-browser.i686: W: spelling-error %description -l en_US filesystems ->
file systems, file-systems, systematizes
guestfs-browser.i686: W: spelling-error %description -l en_US guestfish ->
guest fish, guest-fish, guesthouse
guestfs-browser.src: W: spelling-error Summary(en_US) filesystem -> file
system, file-system, systemically
guestfs-browser.src: W: spelling-error %description -l en_US filesystems ->
file systems, file-systems, systematizes
guestfs-browser.src: W: spelling-error %description -l en_US libguestfs ->
guesthouses
guestfs-browser.src: W: spelling-error %description -l en_US guestfish -> guest
fish, guest-fish, guesthouse
guestfs-browser-debuginfo.i686: E: debuginfo-without-sources
guestfs-browser.src: W: spelling-error Summary(en_US) filesystem -> file
system, file-system, systemically
guestfs-browser.src: W: spelling-error %description -l en_US filesystems ->
file systems, file-systems, systematizes
guestfs-browser.src: W: spelling-error %description -l en_US libguestfs ->
guesthouses
guestfs-browser.src: W: spelling-error %description -l en_US guestfish -> guest
fish, guest-fish, guesthouse
4 packages and 1 specfiles checked; 1 errors, 11 warnings.
[ankur at ankur SRPMS]$

^^ The debuginfo package needs to be corrected. 

SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
^^ koji scratch build is okay

- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

+ requires/provides look sane:
== guestfs-browser-0.1.6-1.fc16.i686.rpm ==
Provides:
guestfs-browser = 0.1.6-1.fc16
guestfs-browser(x86-32) = 0.1.6-1.fc16

Requires:
/usr/bin/gnome-open
/usr/bin/hivexregedit
libatk-1.0.so.0
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.2)
libc.so.6(GLIBC_2.11)
libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.3.2)
libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4)
libc.so.6(GLIBC_2.7)
libcairo.so.2
libdl.so.2
libdl.so.2(GLIBC_2.0)
libdl.so.2(GLIBC_2.1)
libfontconfig.so.1
libfreetype.so.6
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgcc_s.so.1(GCC_3.3.1)
libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0
libgio-2.0.so.0
libglib-2.0.so.0
libgmodule-2.0.so.0
libgobject-2.0.so.0
libgthread-2.0.so.0
libgtk-x11-2.0.so.0
libguestfs >= 1.9.11
libguestfs.so.0
libhivex.so.0
libm.so.6
libm.so.6(GLIBC_2.0)
libm.so.6(GLIBC_2.1)
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangoft2-1.0.so.0
libpng12.so.0
libpthread.so.0
libpthread.so.0(GLIBC_2.0)
libpthread.so.0(GLIBC_2.1)
libpthread.so.0(GLIBC_2.2)
libpthread.so.0(GLIBC_2.3.2)
librt.so.1
libvirt.so.0
libvirt.so.0(LIBVIRT_0.0.3)
libvirt.so.0(LIBVIRT_0.0.5)
libvirt.so.0(LIBVIRT_0.1.0)
libvirt.so.0(LIBVIRT_0.1.1)
libvirt.so.0(LIBVIRT_0.1.4)
libvirt.so.0(LIBVIRT_0.1.5)
libvirt.so.0(LIBVIRT_0.1.9)
libvirt.so.0(LIBVIRT_0.2.0)
libvirt.so.0(LIBVIRT_0.2.1)
libvirt.so.0(LIBVIRT_0.2.3)
libvirt.so.0(LIBVIRT_0.3.0)
libvirt.so.0(LIBVIRT_0.3.2)
libvirt.so.0(LIBVIRT_0.3.3)
libvirt.so.0(LIBVIRT_0.4.1)
libvirt.so.0(LIBVIRT_0.4.2)
rtld(GNU_HASH)

== guestfs-browser-0.1.6-1.fc16.src.rpm ==
Provides:

Requires:
hivex-devel >= 1.2.4-3
libguestfs-devel >= 1.9.11
libvirt-devel
ocaml
ocaml-bitstring-devel
ocaml-camlp4-devel
ocaml-camomile-devel >= 0.8.1
ocaml-camomile-data
ocaml-extlib-devel
ocaml-findlib-devel
ocaml-hivex-devel
ocaml-lablgtk-devel
ocaml-libvirt-devel
ocaml-libguestfs-devel
ocaml-xml-light-devel
/usr/bin/pod2man
/usr/bin/pod2html

== guestfs-browser-debuginfo-0.1.6-1.fc16.i686.rpm ==
Provides:
guestfs-browser-debuginfo = 0.1.6-1.fc16
guestfs-browser-debuginfo(x86-32) = 0.1.6-1.fc16

Requires:

--------------------------------------------------------------------

Issues:

1. The defattr, buildroot, clean sections can be removed. Please let them be if
you intend to build for EPEL etc. as per their guidelines. 

2. Please include a desktop file. Note that you will have to include some
scriptlets when you add it.

3. Please look at the issue with the debuginfo.

Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.