[Bug 725776] Review Request: perl-IRC-Utils - Common utilities for IRC-related tasks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=725776

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2011-07-26 11:15:36 EDT ---
Source tar ball is original. Ok.
Summary verified from lib/IRC/Utils.pm. Ok.
License verified from LICENSE. Ok.
Description verified from lib/IRC/Utils.pm. Ok.
No XS code, noarch build is Ok.
Build-time dependencies Ok.
All tests pass. Ok.

$ rpmlint perl-IRC-Utils.spec ../SRPMS/perl-IRC-Utils-0.10-1.fc16.src.rpm
../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -qlv -p ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jul 26 16:55
/usr/share/doc/perl-IRC-Utils-0.10
-rw-r--r--    1 root    root                     1641 May 22 18:12
/usr/share/doc/perl-IRC-Utils-0.10/Changes
-rw-r--r--    1 root    root                    18449 May 22 18:12
/usr/share/doc/perl-IRC-Utils-0.10/LICENSE
-rw-r--r--    1 root    root                     1399 May 22 18:12
/usr/share/doc/perl-IRC-Utils-0.10/META.json
-rw-r--r--    1 root    root                    11893 May 22 18:12
/usr/share/doc/perl-IRC-Utils-0.10/README
-rw-r--r--    1 root    root                      582 May 22 18:12
/usr/share/doc/perl-IRC-Utils-0.10/dist.ini
-rw-r--r--    1 root    root                     6234 Jul 26 16:55
/usr/share/man/man3/IRC::Utils.3pm.gz
drwxr-xr-x    2 root    root                        0 Jul 26 16:55
/usr/share/perl5/vendor_perl/IRC
-rw-r--r--    1 root    root                    29774 May 22 18:12
/usr/share/perl5/vendor_perl/IRC/Utils.pm
File layout and permissions Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm
|sort |uniq -c
      1 perl(base)  
      1 perl(constant)  
      1 perl(Encode)  
      1 perl(Encode::Guess)  
      1 perl(Exporter)  
      1 perl(:MODULE_COMPAT_5.14.1)  
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Run-time requires Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm
|sort |uniq -c
      1 perl(IRC::Utils) = 0.10
      1 perl-IRC-Utils = 0.10-1.fc16
Run-time provides Ok.

$ resolvedeps dist-f16-build
../RPMS/noarch/perl-IRC-Utils-0.10-1.fc16.noarch.rpm
Binary dependencies resolvable. Ok.

Package builds in F16
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3231475). Ok.

Package is in line with Fedora and Perl packaging guidelines.


Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.