[Bug 710995] Review Request: kradview - An image viewer oriented to images obtained by X-Ray machines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710995

Veeti Paananen <veeti.paananen at rojekti.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veeti.paananen at rojekti.fi

--- Comment #10 from Veeti Paananen <veeti.paananen at rojekti.fi> 2011-07-26 12:22:50 EDT ---
Some comments:

- I think that the "get rid of build error" sed command should go to a patch
file. The patch should be sent to upstream.

- At least some of the desktop file modifications (if not all) can be done with
desktop-file-install. A patch would probably work too.

- Join the two "correct permissions" sections for clarity, instead of having
them split by the UTF-8 conversion.

- You could do something like "%{_datadir}/icons/hicolor/*x*/apps/%{name}.png"
in the files section to avoid the two lines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.