[Bug 684938] Review Request: wmdrawer - Retractable button bar launcher dockapp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684938

--- Comment #7 from Mario Blättermann <mariobl at freenet.de> 2011-07-26 15:02:13 EDT ---
OK, I've patched the Makefile to concatenate the sed commands and the use of
gdk-pixbuf2. Now it works fine.

Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3232188

(In reply to comment #3)
> 
> 1. Problem: The file-size-mismatch. Did you alter the source archive? Or maybe
> upstream tweaked something without creating a new version?
Nothing done with the sources,really. I don't understand it... I've downloaded
the sources again and used them for the new package. That's all I can do for
now.
> 
> 2. All the wrong-file-end-of-line-encoding and file-not-utf8 errors should
> probably be fixed with "dos2linux -k <file>" after "make install". 
> 
Not dos2linux, but dos2unix is available from the yum repos. But dos2unix seems
to need an input declaration. Is there a more simple way to convert the files
to utf-8 with correct line breaks?

> 3. The incorrect-fsf-address is nothing you can fix but should be reported
> upstream.
It is a common problem in older software, such as a lot of WindowMaker
dockapps. Upstream is dead in most cases. Well, I could fix it by patching the
source files and COPYING, but I think it isn't worth the effort.

(In reply to comment #4)
[...]

> 6. Not really a problem but you could (if you wanted to) replace the last two
> arguments to %doc with:
> 
> doc/*.smgl
> 
What's the reason for that? I don't know about *.smgl files... Normally, the
sgml files should be processed with docbook2man to get a manpage. Actually, I
can drop the English version, because there is already a real manpage. The
Italian version seems to be incomplete, given the file size. In my opinion, the
sgml files should be dropped completely.

New files:

Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmdrawer.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/wmdrawer-0.10.5-10.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.