[Bug 721179] Review Request: rubygem-extlib - Support library for DataMapper and Merb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721179

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch at redhat.com

--- Comment #11 from Vít Ondruch <vondruch at redhat.com> 2011-07-27 03:42:47 EDT ---
(In reply to comment #10)
> Looks good. APPROVED.

Hi Ryan, the package is FTBFS. Could you please revoke the APPROVED?

1) The test suite is not executed at all. I would suggest to execute the test
suite using spec instead of rake. That would allow to remove the patch.
2) The YARD documentation is generated in %check section. That is not correct
place.
3) I would suggest to not provide the ruby subpackage unless there is real need
for it.
4) If that is .spec file recycled from EPEL, I would expect to see there the
original changelog.
5) The BuildRoot is not necessary unless the spec is used to build EPEL5. In
that case I would suggest to put there some condition to be clear.
6) defattr in files section is not necessary anymore
7) %clean section is not required

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.