[Bug 726080] Review Request: Xnee - X11 environment recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=726080

--- Comment #2 from Matthieu Saulnier <casper.le.fantom at gmail.com> 2011-07-28 17:35:23 EDT ---
(In reply to comment #1)
> Hi Casper,
Hello

> 
> first of all, please enter your full real name in the bugzilla preferences and
> also use it in the spec's %changelog.
Done

> 
> Here are a couple of quick comments on your package:
> - Use the main GNU URL in Source0:
>   ftp://ftp.gnu.org/gnu/xnee/xnee-%{version}.tar.gz
Done

> 
> - Is this release really a pre-release (rc1)? I can't find any information
>   on this.
I made a mistake by reading the wiki. Corrected

> 
> - According to the source file headers, the license of xnee is GPLv3+.
Done

> 
> - The package currently doesn't build because of missing BuildRequires:
>   libXtst-devel
>   gtk+-devel
>   gtk2-devel
Done

> 
> - As the package provides a GUI application, you must add and install a
>   .desktop file as described here:
>   http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
Done

> 
> - The tarball contains the sources of libxnee. I suggest to build the shared 
>   library and package it as well. It could be useful for other packages 
>   and/or developers.
Yes, my SPEC file is for xnee. I will package libxnee, cnee and gnee from the
tarball... If you agree.

> 
> - If you plan to build the package for EPEL < 6 as well, add 
>   rm -rf %{buildroot}
>   at the beginning of the %install section.
Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.