[Bug 690728] Review Request: Nitrate - A test case management system written in Django

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690728

--- Comment #31 from Jens Petersen <petersen at redhat.com> 2011-05-31 22:10:26 EDT ---
Thanks for the update and sorry for the delay...

Few more things I noticed:

- why do you require Django = 1.2.3 ?

No current releases are using that version:
https://admin.fedoraproject.org/community/?package=Django#package_maintenance

- you have mod_python commented out as a requires

- "BuildRoot: " is now redundant and can be dropped
  - please also drop the %clean section
    and "rm -rf $RPM_BUILD_ROOT" from %install.

- there is no changelog entry for the latest changes you made in .spec
  - please bump the release field when you update the package
  - you need to add a changelog each time to document the changes you have made

- further if you change the tarball you should really bump the version

http://yuwang.fedorapeople.org/nitrate-3.3.4-1.src.rpm seems to be broken.

(BTW you don't have to upload the tarball to people since it should live at:
https://fedorahosted.org/releases/n/i/nitrate/ anyway:)

- I am not sure it is really necessary (or good idea) to put
  the release also into the page footer.  Any any functional
  changes would come from the version not the release.  But
  I don't think it needs to block the review. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.