[Bug 709791] New: Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 1 16:07:14 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

https://bugzilla.redhat.com/show_bug.cgi?id=709791

           Summary: Review Suggestions for Tomcat - Apache Servlet/JSP
                    Engine, RI for Servlet 3.0/JSP 2.2 API
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: ole.ersoy at gmail.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---


The bindir definition can be shortened by replacing 
%{_datadir}/%{name}
with 
%{homedir}

Might want to replace "tomcat" with %{name} in the add user and group block:

# add the tomcat user and group
%{_sbindir}/groupadd -g %{tcuid} -r tomcat 2>/dev/null || :
%{_sbindir}/useradd -c "Apache Tomcat" -u %{tcuid} -g tomcat \
    -s /bin/nologin -r -d %{homedir} tomcat 2>/dev/null || :

In the line:
%{_javadir}/%{name}/%{name}-el-%{elspec}-api.jar


%{_javadir}/%{name} can be replaced with:
%{libdir}?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list