[Bug 708475] Review Request: pysdm - Python based Storage Device Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708475

--- Comment #5 from Richard Shaw <hobbes1069 at gmail.com> 2011-06-01 16:30:25 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > I'm still learning how licences work... I thought that when COPYING said GPL
> > Version two that it meant GPLv2... I knew the L was "Lesser" but didn't know
> > that GNU Library == "Lesser"
> > 
> > So it should be LGPL?
> 
> "LGPLv2+" in particular; see the entry for "GNU Lesser General Public License
> (no version)" here: https://fedoraproject.org/wiki/Licensing#Good_Licenses.

Done.


> > Ok, what do we do here? It doesn't appear to be already packaged for Fedora so
> > this package would be the only user. Do we need a separate review request?
> 
> I'm afraid so.  I'll be happy to review that one for you, too.

I've got one pretty much ready but ran into an issue, see below.


> > Strangely enough only SimpleGladeApp.py seems to make it into the rpm
> > package...
> 
> Oh yeah?  Does it look like tepache.py should be in there too?

Ok, so pysdm only appears to use SimpleGladeApp.py astepache.py is intended as
a binary, not a library. I'm guessing the pysdm group just pulled in all of the
tepache package instead of just using SimpleGladeApp.py, which BTW, is ALL OVER
THE PLACE in on the web and in other distros. Looks like it's been widely
copied in many projects.

Also, a problem:
# yum whatprovides /usr/lib/*/site-packages/SimpleGladeApp.py
Loaded plugins: changelog, presto, refresh-packagekit, remove-with-leaves,
rpm-warm-cache
gresistor-0.0.1-17.fc14.noarch : Gnome resistor color code calculator
Repo        : fedora
Matched from:
Filename    : /usr/lib/python2.7/site-packages/SimpleGladeApp.py

I'm assuming that once tepache gets approved that the gresistor maintainer will
have to fix his package, right?

And this was supposed to be a simple one :)

Thanks,
Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.