[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708765

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de
               Flag|fedora-review?              |

--- Comment #19 from Martin Gieseking <martin.gieseking at uos.de> 2011-06-01 17:14:24 EDT ---
Hi Mario, here are some comments on the latest spec:

- building the package with mock fails because of missing BR: intltool

- You should drop the flags "-Wall -g0 -O2" from CFLAGS in file configure.ac 
  as they overwrite Fedora's %optflags and lead to debuginfo packages without 
  sources.

- drop the trailing asterisk from %{_datadir}/%{name}/* for proper directory 
  ownership

I cleared the fedora-review flag as it should be set by the reviewer and you
can't review your own packages. ;)


$ rpmlint *.rpm
frogr.src: W: spelling-error Summary(en_US) Flickr -> Flick, Flicker, Flicks
frogr.src: W: spelling-error Summary(de) Flickr -> Flicker, Flicke, Flickt
frogr.x86_64: W: spelling-error Summary(en_US) Flickr -> Flick, Flicker, Flicks
frogr.x86_64: W: spelling-error Summary(de) Flickr -> Flicker, Flicke, Flickt
frogr-debuginfo.x86_64: E: debuginfo-without-sources
3 packages and 0 specfiles checked; 1 errors, 4 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.