[Bug 708765] Review Request: Frogr - Flickr Remote Organizer for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=708765

--- Comment #24 from Martin Gieseking <martin.gieseking at uos.de> 2011-06-02 03:07:15 EDT ---
CFLAGS also defines some preprocessor constants (-DG_DISABLE_ASSERT
-DG_DISABLE_CHECKS -DG_DISABLE_CAST_CHECKS) that probably have to be added when
overwriting CFLAGS in the make statement. I'm not sure if they are actually
required, though.

Mario Sanchez Prada, since it's a bad idea to hard-code -g0 and -O2 in
configure.ac, I suggest to remove them in the next release.


Also, the source headers contain a wrong FSF address. It's recommended to use
the wording mentioned in COPYING:
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.


frogr seems to use the bundled library flicksoup (src/flicksoup) which is
available at http://gitorious.org/flicksoup. This is not allowed in Fedora. The
library must be packaged separately.
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.